FAQ SearchLogin
Tuxera Home
View unanswered posts | View active topics It is currently Wed Jun 16, 2021 15:31



Post new topic Reply to topic  [ 3 posts ] 
typo in error message 
Author Message

Joined: Wed Sep 28, 2011 01:03
Posts: 4
Post typo in error message
Hello,

c.f. https://bugs.launchpad.net/bugs/860871

In ntfsresize.c from the Ubuntu Oneiric package version 1:2011.4.12AR.4-2ubuntu2 we have the following:

if (fsck->multi_ref)
err_printf("%d clusters are referenced multiply"
" times.\n", fsck->multi_ref);

That should likely be "referenced multiple times".

While looking at the code, I found the same likely typo in a total of four files (based on our soruce for Oneiric (version string 1:2011.4.12AR.4-2ubuntu2); although the above is the only one that will be shown to an user, I went ahead and changed all four.

Unfortunately, I cannot find a place to submit the patch here. As such, I have added a branch in the Ubuntu bug with it. I would have attached the diff here, but the forum software is complaing about the file extention.

Please correct me as needed.

Cheers,


Wed Sep 28, 2011 01:37
Profile
NTFS-3G Lead Developer

Joined: Tue Sep 04, 2007 17:22
Posts: 1286
Post Re: typo in error message
Hi,

Quote:
That should likely be "referenced multiple times".

Indeed. Thank you for reporting.
Quote:
While looking at the code, I found the same likely typo in a total of four files
Unfortunately, I cannot find a place to submit the patch here.

You can attach the patch to your reply, I will take care of it. However this forum only accepts compressed attachments, so you have to compress your patch file first (.gz, .bz2, etc.)

As the patch is probably small, you can also paste it with your reply.

Regards

Jean-Pierre


Wed Sep 28, 2011 09:14
Profile

Joined: Wed Sep 28, 2011 01:03
Posts: 4
Post Re: typo in error message
Patch inline below.

Thank you,

Code:
=== modified file 'TODO.ntfsprogs'
--- TODO.ntfsprogs   2007-09-22 15:29:16 +0000
+++ TODO.ntfsprogs   2011-09-27 23:11:39 +0000
@@ -64,7 +64,7 @@
* ntfscp *
**********

-- add ability to copy multiply files at once.
+- add ability to copy multiple files at once.


***********

=== modified file 'include/ntfs-3g/layout.h'
--- include/ntfs-3g/layout.h   2010-12-21 14:51:07 +0000
+++ include/ntfs-3g/layout.h   2011-09-27 23:11:39 +0000
@@ -2224,10 +2224,10 @@
   SID sid;      /* The SID of the user/object associated with
               this quota entry. If this field is missing
               then the INDEX_ENTRY is padded with zeros
-               to multiply of 8 which are not counted in
+               to multiples of 8 which are not counted in
               the data_length field. If the sid is present
               then this structure is padded with zeros to
-               multiply of 8 and the padding is counted in
+               multiples of 8 and the padding is counted in
               the INDEX_ENTRY's data_length. */
} __attribute__((__packed__)) QUOTA_CONTROL_ENTRY;


=== modified file 'libntfs-3g/runlist.c'
--- libntfs-3g/runlist.c   2011-08-04 13:49:36 +0000
+++ libntfs-3g/runlist.c   2011-09-27 23:11:39 +0000
@@ -1678,7 +1678,7 @@
   /**
    * Reallocate memory if necessary.
    * FIXME: Below code is broken, because runlist allocations must be
-    * a multiply of 4096. The code caused crashes and corruptions.
+    * a multiple of 4096. The code caused crashes and corruptions.
    */
/*   
    if (!is_end) {

=== modified file 'ntfsprogs/ntfsresize.c'
--- ntfsprogs/ntfsresize.c   2011-09-23 09:28:42 +0000
+++ ntfsprogs/ntfsresize.c   2011-09-27 23:11:39 +0000
@@ -2717,7 +2717,7 @@
         err_printf("%d clusters are referenced outside "
               "of the volume.\n", fsck->outsider);
      if (fsck->multi_ref)
-         err_printf("%d clusters are referenced multiply"
+         err_printf("%d clusters are referenced multiple"
               " times.\n", fsck->multi_ref);
      printf("%s", corrupt_volume_msg);
      exit(1);



Wed Sep 28, 2011 14:48
Profile
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 


Who is online

Users browsing this forum: No registered users and 6 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Original forum style by Vjacheslav Trushkin.